Fix UG for CS2101 submission #559
Conversation
A hotfix. Awaits proper fix to parser.
Codecov Report
@@ Coverage Diff @@
## master #559 +/- ##
============================================
- Coverage 65.25% 65.05% -0.21%
+ Complexity 737 736 -1
============================================
Files 147 147
Lines 2590 2598 +8
Branches 282 285 +3
============================================
Hits 1690 1690
- Misses 749 753 +4
- Partials 151 155 +4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| To view more information, refer to the [Layout](/UserGuide.html#layout) section of the User Guide. | ||
| To view more information, refer to the [Layout](#layout) section of the User Guide. |
There was a problem hiding this comment.
I think this line breaks for the DG, seeing how the pipeline is failing as well. This section is supposed to show in the DG and link to the UG's layout section so just [Layout](#layout) doesn't seem to be working for the DG tho it does fix the broken link for UG.
Alternatively, since the actual link we want is https://ay2223s1-cs2103t-w16-2.github.io/tp/UserGuide.html#layout while the previous link links to https://ay2223s1-cs2103t-w16-2.github.io/UserGuide.html#layout, maybe just adding the missing /tp like [Layout](/tp/UserGuide.html#layout) would suffice.
| To view more information, refer to the [Layout](/UserGuide.html#layout) section of the User Guide. | ||
| To view more information, refer to the [Layout](#layout) section of the User Guide. |
| To view more information, refer to the [Layout](/UserGuide.html#layout) section of the User Guide. | ||
| To view more information, refer to the [Layout](#layout) section of the User Guide. |
There was a problem hiding this comment.
Yup, this needs to be fixed, but this is not the fix. The issue is that if we don't use a fragment, this will break the PDF version of the UG since it will try to open a website instead. Working on a fix in the validation.
| To view more information, refer to the [Layout](/UserGuide.html#layout) section of the User Guide. | ||
| To view more information, refer to the [Layout](#layout) section of the User Guide. |
There was a problem hiding this comment.
Yup, this needs to be fixed, but this is not the fix. The issue is that if we don't use a fragment, this will break the PDF version of the UG since it will try to open a website instead. Working on a fix in the validation.
No description provided.